Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network: Firewall API #2140

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Network: Firewall API #2140

merged 1 commit into from
Nov 15, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Nov 13, 2023 •
edited by francescodanzi
Loading

Description

This PR introduces the FirewallConfiguration API

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 force-pushed the frc/nftapi branch 3 times, most recently from bb37096 to 102beb1 Compare November 15, 2023 10:29
@cheina97 cheina97 force-pushed the network-external branch 2 times, most recently from ba4daf3 to b802989 Compare November 15, 2023 10:36
@cheina97 cheina97 marked this pull request as ready for review November 15, 2023 10:44
@cheina97 cheina97 force-pushed the frc/nftapi branch 2 times, most recently from 0ed364f to 76e2a4e Compare November 15, 2023 11:05
@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Nov 15, 2023
@adamjensenbot adamjensenbot merged commit c35ff41 into liqotech:network-external Nov 15, 2023
16 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Nov 15, 2023
@cheina97 cheina97 deleted the frc/nftapi branch November 15, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@fra98 fra98 Awaiting requested review from fra98

@francescodanzi francescodanzi Awaiting requested review from francescodanzi

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheina97 @adamjensenbot @aleoli